Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change replaceAll usage introduced in #35566 #37473

Merged
merged 1 commit into from Nov 11, 2022
Merged

fix: change replaceAll usage introduced in #35566 #37473

merged 1 commit into from Nov 11, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Nov 11, 2022 •
edited by XhmikosR

Description

fix: change replaceAll usage . Introduced at #35566

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@GeoSot GeoSot requested a review from XhmikosR November 11, 2022 08:32
@GeoSot GeoSot requested a review from a team as a code owner November 11, 2022 08:32
@XhmikosR XhmikosR added v5 and removed regression labels Nov 11, 2022
@XhmikosR XhmikosR changed the title fix: change replaceAll usage . Introduced at #35565 fix: change replaceAll usage introduced in t #35565 Nov 11, 2022
@XhmikosR XhmikosR changed the title fix: change replaceAll usage introduced in t #35565 fix: change replaceAll usage introduced in #35566 Nov 11, 2022
@XhmikosR XhmikosR merged commit 0a484e7 into main Nov 11, 2022
@XhmikosR XhmikosR deleted the gs/fix-replace-all-usage branch November 11, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js v5
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeoSot @XhmikosR