Docs: new section to explain how to add a new color to the theme #37737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-add-doc-for-sass-custom-colors
branch
from
7c5dba8
to
c7d9da4
Compare
julien-deramond
changed the title
2 tasks
mdo
force-pushed
the
main-jd-add-doc-for-sass-custom-colors
branch
from
c7d9da4
to
cca0a27
Compare
mdo
approved these changes
Jan 15, 2023
|
Putting it in draft. Before merging it, IMO we should also introduce how to have custom values for the dark mode with:
|
|
I've finalized this PR with the following modifications:
@mdo I re-request a review for this PR now ready for final review |
mdo
approved these changes
May 17, 2023
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
…s#37737) * Docs: new section to explain how to add a new color to the theme * Commit to revert * Edit copy * Typo * bundlewatch * Restore blog example * Remove Sass modifications * Complete documentation * Revert bootstrap.scss modifications --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests adding a new section in our docs somewhere to explain how to add a new color in our theme colors which are not as easy as before after the new color modes.
Would love to have feedback/ideas from @twbs/css-review 🙏
This PR can be tested directly at https://stackblitz.com/edit/github-woyaxg?file=src%2Fscss%2Fstyles.scss,src%2Findex.html or by forking it.
Motivation & Context
IMO this change is required for our users to understand how to play with the theme colors.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Mentioned in #37549