Remove outdated comment from $input-border-color variable
#37868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fc3f4b6,
$input-border-colorwas set to$gray-400. It is now set tovar(--bs-border-color)instead, which returns$gray-300. You can see the slight change by comparing v5.2 docs to v5.3 docs, or in the following GIF:I imagine this change was intentional, as #35857 specifically mentions using a global
border-color. In that case, we should remove the comment, as this PR does, to avoid confusion.Otherwise,
$input-border-colorshould be set to another custom property that translates to$gray-400as before.See also #37835 for a similar, recently merged PR.