Fix missing modifications when --bs-{color}-text was changed to --bs-{color}-text-emphasis
#38176
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs-{color}-text-emphasis`
20 tasks
mdo
approved these changes
Mar 7, 2023
julien-deramond
deleted the
main-jd-fix-missing-modification-for-text-emphasis
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
15744ee introduced the following change:
bs-{color}-text→bs-{color}-text-emphasisThis PR fixes some missing modifications in:
scss/tests/mixins/_color-modes.test.scssscss/_variables.scssthat fixes the rendering of the active text color in both light and dark modesPlease double-check that we haven't forgotten other things with different combinations of
--bs-{color}-textand/or--#{$prefix}{color}-text.Type of changes
Checklist
npm run lint)Live previews