Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove unnecessary href and tabindex="-1" #38196

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

Description

Remove unnecessary href and tabindex="-1". The ones remaining in the buttons and in the interactions seem pretty legit for me.

Motivation & Context

Coherence inside the doc.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@mdo mdo merged commit 2032a6a into main Mar 10, 2023
@mdo mdo deleted the main-lmp-disabled-links branch March 10, 2023 17:17
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants