Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Proposal to use scroll-margin-top instead padding and margin #38220

Merged
merged 1 commit into from Mar 20, 2023
Merged

Docs: Proposal to use scroll-margin-top instead padding and margin #38220

merged 1 commit into from Mar 20, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 13, 2023 •
edited

Description

Use the newly approved CSS property for :target

Motivation & Context

remove some small shifts introduced in the doc.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #36278.
Superseed #36280.

@louismaximepiton louismaximepiton requested a review from a team as a code owner March 13, 2023 14:53
@julien-deramond
Copy link
Member

Might superseed #36280 and close #36278

@louismaximepiton louismaximepiton mentioned this pull request Mar 14, 2023
Open
mdo
mdo approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@louismaximepiton louismaximepiton mentioned this pull request Mar 17, 2023
Merged
13 tasks
@mdo mdo merged commit a6d8aa8 into main Mar 20, 2023
20 of 21 checks passed
@mdo mdo deleted the main-lmp-handle-scroll-target branch March 20, 2023 00:45
@julien-deramond julien-deramond mentioned this pull request Mar 20, 2023
Closed
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.3.0-alpha2
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc: Extra top padding after having clicked on anchor links
3 participants
@louismaximepiton @julien-deramond @mdo