Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-link.md: remove moot aliases #38246

Merged
merged 2 commits into from
Mar 17, 2023
Merged

icon-link.md: remove moot aliases #38246

merged 2 commits into from
Mar 17, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 15, 2023

@mdo is this referenced anywhere? It was introduced in #37762 which wasn't deployed AFAICT (it's created after 5.3.0-alpha1 and I couldn't find any reference to it so it might be moot.

@XhmikosR XhmikosR requested a review from mdo March 15, 2023 20:19
@XhmikosR XhmikosR marked this pull request as ready for review March 15, 2023 20:22
@julien-deramond
Copy link
Member

Forgot to create a PR to do this exact same modification. We were wondering the same thing while integrating into our fork. Also thinking it's moot.

@XhmikosR
Copy link
Member Author

I'm going to land this since it seems moot. We can bring it back later if needed

@XhmikosR XhmikosR merged commit 8701d89 into main Mar 17, 2023
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch March 17, 2023 05:58
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Mar 17, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants