-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for interpolated variables to node-sass
workflow and fix wrong variables
#38283
Conversation
better to implement stylelint |
Do you mean to check our Sass files to avoid to forget any interpolations, or in the GitHub workflow that tries the compilation with |
|
Just tried it. The following use case generates an error like explained in the example: .class {
$var: "my-anim";
animation-name: $var;
// ↑
// This variable needs to be interpolated
// because its value is a string
} But |
@julien-deramond maybe we should split the fixes to a new PR so that we merge it and then merge the CI change? |
Having everything in the same place, for now, is easier for me right to have a global view. |
@julien-deramond @danny007in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, @julien-deramond! Feel free to merge whenever.
I've double-checked a part of the use cases. Interpolation is working well. Since @mdo has already reviewed it, let's |
It should have been split into separate PRs... Anyway, keep it on mind for the future. Because the Sass changes were real bugs and unrelated to the CI addition. |
node-sass
workflow and fix wrong variables
node-sass
workflow and fix wrong variablesnode-sass
workflow and fix wrong variables
Description
This PR closes #38278:
node-sass
workflow and fix wrong variables #38283 (comment))Type of changes
Checklist
npm run lint
)Related issues
Closes #38278