Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix floating-labels min-height #38366

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Mar 29, 2023

Description

fix floating-labels min-height. textareas have other min-height as normal textareas

i have set it for all input, maybe it is better only for textareas?

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@jonnysp jonnysp requested a review from a team as a code owner March 29, 2023 06:03
@mdo
Copy link
Member

mdo commented Apr 1, 2023

Not sure we need it? Textarea height is covered at http://getbootstrap.com/docs/5.3/forms/floating-labels/#textareas. Does this fix a bug or something we have right now?

@jonnysp
Copy link
Contributor Author

jonnysp commented Apr 2, 2023

is for floating labels textarea min-height not for height

in normal textareas is set, but is to small for floating textareas.

grafik

@Sysix
Copy link

Sysix commented Apr 4, 2023

I could reproduce this bug my manually resizing the textarea with the browsers resize icon (bottom right).

@jonnysp
Copy link
Contributor Author

jonnysp commented Apr 5, 2023

yes, but it is only in FF, Edge and Chrome on windows. in Safari on MAC everything is fine.
Screenshot-2023-04-05-091443

@mdo mdo merged commit 10afeb5 into twbs:main Apr 21, 2023
13 checks passed
@jonnysp
Copy link
Contributor Author

jonnysp commented Apr 21, 2023

nice

@jonnysp jonnysp deleted the fix-floating-labels-minheight-textarea branch April 21, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants