Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change-version.js: handle rubygems specific version number #38452

Merged
merged 6 commits into from
Apr 12, 2023
Merged

change-version.js: handle rubygems specific version number #38452

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b22d6c9
Handle Ruby specific version in `change-version.js`
julien-deramond Apr 12, 2023
4d585c9
Fixes
XhmikosR Apr 12, 2023
19efd0a
Guard against the same version
XhmikosR Apr 12, 2023
bcc3bf0
Update change-version.js
XhmikosR Apr 12, 2023
492b336
Update change-version.js
XhmikosR Apr 12, 2023
69544eb
Update change-version.js
XhmikosR Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion build/change-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,15 @@ function regExpQuoteReplacement(string) {

async function replaceRecursively(file, oldVersion, newVersion) {
const originalString = await fs.readFile(file, 'utf8')
const newString = originalString.replace(
var newString = originalString.replace(
XhmikosR marked this conversation as resolved.
Show resolved Hide resolved
new RegExp(regExpQuote(oldVersion), 'g'), regExpQuoteReplacement(newVersion)
)

// Also replace the version used by Ruby sometimes in this case: '5.3.0.alpha3' which is different from '5.3.0-alpha3'
newString = newString.replace(
new RegExp(regExpQuote(oldVersion.replace(/-/g,'.')), 'g'), regExpQuoteReplacement(newVersion)
)

// No need to move any further if the strings are identical
if (originalString === newString) {
return
Expand Down