Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-modes.js to bootstrap-x.y.z-examples.zip #38747

Merged
merged 1 commit into from Jun 18, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 12, 2023

Description

As described in #38746, new color-modes.js asset was not including in bootstrap-x.y.z-examples.zip.
This PR modifies build/zip-examples.js which is used to create the corresponding directory.

/cc @XhmikosR for a possible v5.3.1

How to test

Locally:

$ npm run release
$ unzip bootstrap-5.3.0-examples.zip
$ php -S localhost:800 # Or run another local server

Then go to http://localhost:8008/album and change the color mode

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Related issues

Closes #38746

@XhmikosR XhmikosR merged commit 5036f70 into main Jun 18, 2023
15 checks passed
@XhmikosR XhmikosR deleted the main-jd-add-color-modes-to-examples-zip branch June 18, 2023 14:52
@XhmikosR XhmikosR added the build label Jul 26, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Examples download "bootstrap-5.3.0-examples.zip" is missing file for dark mode "color-modes.js"
2 participants