Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove incorrect mention of .left- and .right- utilities from migration guide #39054

Merged
merged 1 commit into from Aug 22, 2023
Merged

Docs: Remove incorrect mention of .left- and .right- utilities from migration guide #39054

merged 1 commit into from Aug 22, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Aug 15, 2023

Description

There are no classes in Bootstrap 4.x beginning with .left- or .right-.

(You can do a CTRL+F on https://cdn.jsdelivr.net/npm/bootstrap@4.6.2/dist/css/bootstrap.css to check)

Motivation & Context

Make the migration guide easier to follow. :-)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

There are no classes in Bootstrap 4.x beginning with `.left` or `.right`.

(You can do a `CTRL`+`F` on https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.css to check)
@coliff coliff changed the title Remove incorrect mention of .left- and .right- utilities from migration guide Docs: Remove incorrect mention of .left- and .right- utilities from migration guide Aug 15, 2023
@XhmikosR
Copy link
Member

XhmikosR commented Aug 15, 2023

The CSS you are linking is from v5.3.1.

The message probably should read:

- Renamed `.*-left` and `.*-right` to `.*-start` and `.*-end`.

But if we list all of the renames, we might not need that sentence.

@coliff
Copy link
Contributor Author

coliff commented Aug 15, 2023

The CSS you are linking is from v5.3.1.

Oops, I edited my post. Bootstrap 4.x doesn't have any classes beginning with .left- or .right- so I think that sentence can be removed altogether. We list all the renames below anyway.

@XhmikosR XhmikosR merged commit 6091dba into twbs:main Aug 22, 2023
15 checks passed
@coliff coliff deleted the migrate-guide-fix branch August 22, 2023 08:25
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
…s#39054)

There are no classes in Bootstrap 4.x beginning with `.left` or `.right`.

(You can do a `CTRL`+`F` on https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.css to check)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants