Doc: use .text-bg-{color} for all badges
#39214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Since we don't have a different color palette for dark mode, it looks harmful for basic users.
However, for advanced users that might want to implement a different color palette using dark mode, they might have some issues because :
The calculated color value from .text-bg-* helper comes from color-contrast() applied on theme-colors so it won't support CSS variables. -> Should we introduce something to handle this use case ?
louismaximepiton
approved these changes
Oct 13, 2023
|
@mdo friendly ping for a double-check :) Adding you as a reviewer. If not available, don't hesitate to tell me, and then we'll merge the PR. |
mdo
approved these changes
Oct 23, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests using
.text-bg-{color}all the time when badges are used.Note that https://deploy-preview-39214--twbs-bootstrap.netlify.app/docs/5.3/utilities/position/#examples still uses
.bg-dangeras there's no text in this rounded badge.Motivation & Context
The rendering is the same in Bootstrap documentation because the same color palette is used whether we are in light or dark mode (see our
$theme-colors).However, when a project needs to have specific colors for the dark mode, it needs to create a
$theme-colors-dark. It will imply that the background and text colors will be different for.text-bg-{color}.Without this change, our badges would have the right background color in dark mode, but the text color wouldn't be the right one.
Type of changes
Checklist
npm run lint)Live previews