Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use urls.JoinPath in more places #39778

Merged
merged 4 commits into from Mar 22, 2024
Merged

docs: use urls.JoinPath in more places #39778

merged 4 commits into from Mar 22, 2024

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 12, 2024 •
edited

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the docs label Mar 12, 2024
@XhmikosR XhmikosR changed the title versions.md: use urls.JoinPath docs: use urls.JoinPath in more places Mar 12, 2024
@XhmikosR XhmikosR changed the title docs: use urls.JoinPath in more places docs: use urls.JoinPath in more places Mar 12, 2024
@XhmikosR XhmikosR marked this pull request as ready for review March 20, 2024 16:09
@XhmikosR XhmikosR merged commit 11037f8 into main Mar 22, 2024
14 checks passed
@XhmikosR XhmikosR deleted the xmr/joinpath branch March 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
docs
Projects
v5.3.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @julien-deramond