Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the background color #39854

Closed
wants to merge 2 commits into from
Closed

changed the background color #39854

wants to merge 2 commits into from

Conversation

joel6948
Copy link

@joel6948 joel6948 commented Apr 2, 2024

change for this issue
#39849 (comment)

@joel6948 joel6948 requested a review from a team as a code owner April 2, 2024 05:13
@joel6948 joel6948 mentioned this pull request Apr 2, 2024
2 tasks
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @joel6948
Before we can review this PR:

  • Please use the PR template and describe your changes and maybe show what's the rendering based on the original issue with a screenshot or whatever
  • Please fix the lint issues
  • Probably use a new Sass variable if $form-range-thumb-bg can't be used. But please bear in mind that it was used before also in &::-webkit-slider-thumb rule. There's nothing to do here?

@joel6948
Copy link
Author

joel6948 commented Apr 2, 2024

Proposal
I can see the ticks if I don't include the bootstrap form-range class. But whenever I add that class, the ticks are gone.

<input type="range" min="100" max="500" class="form-range" list="range-list">
<datalist id="range-list">
   <option value="100">
   <option value="200">
   <option value="300">
   <option value="400">
   <option value="500">
</datalist>

Motivation and context
Functionality is already there in the browser, but it's not working with Bootstrap.

added some changes regarding the sass varibale

@julien-deramond julien-deramond marked this pull request as draft April 2, 2024 07:08
@julien-deramond
Copy link
Member

I'm sorry, but I'm closing this PR @joel6948
The description hasn't been changed, there's no explanation on how the change does the work required in the issue.
There's still a linter issue.
Moreover, there's a regression on Chrome where the thumb is now black in light/dark mode instead of the right color:

Screenshot 2024-04-02 at 09 19 04

Feel free to recreate a PR later on containing all the required content after having tested everything locally.

@joel6948 joel6948 deleted the new-feature branch April 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants