-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify link styling using :is(), to avoid additional rule with :not(). #40439
base: main
Are you sure you want to change the base?
Conversation
Thanks for this PR @donquixote |
Alright, thanks for the quick response! I don't have any investment in this atm, I just wanted to share this idea before I forget about it. Btw, can we use |
I pushed a version with |
Thanks for that. I changed the label to v5 instead of v6. |
Btw we could use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @donquixote
I haven't looked at the code yet, but just in terms of rendering in the deployed documentation at https://deploy-preview-40439--twbs-bootstrap.netlify.app/, there are several regressions in the homepage:
- These links shouldn't be underlined:
- In this button, the text should have the right color and shouldn't be underlined:
There are a lot of problems too in the side menu:
Note: tested only with macOS 14.4.1 / Firefox 126.0
Description
Use a single rule with
a:is(...) {
instead ofa {
+a:not(...)
for link styling.Motivation & Context
In
_reboot.scss
we have link styling that is immediately countered by a more specific rule to undo the styling on named anchors. The:not()
part was introduced in #19402 and refined in #30726.This is awkward and can be simplified.
Type of changes
Checklist
npm run lint
)(I shall review the points later)
Live previews
Related issues