Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled buttons get colored error fixed #40608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Riyazul555
Copy link

@Riyazul555 Riyazul555 commented Jul 6, 2024

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40557

@Riyazul555 Riyazul555 requested a review from a team as a code owner July 6, 2024 08:38
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR @Riyazul555
I haven't looked at the issue in detail, but here's already a first quick feedback.
There's something to do with --#{$prefix}btn-disabled-opacity as in your version, this CSS variable is no more used at all.
And you also set background-color two times for the same rule (can be seen also by running npm run lint locally).

@Riyazul555
Copy link
Author

Ok I got it @julien-deramond
I have made new changes
Please check out
Thanks

@rr-it
Copy link

rr-it commented Jul 11, 2024

This PR makes the ligtness of disabled buttons fixed. Disabled buttons should fade into the background , so the lightness has to change depending on which background a button is put on.
So this does not close the mentioned issue.

@Riyazul555 There is already an open PR for the issue. Please see #40559 – feedback welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled buttons get colored on colorful background
4 participants