Bump Sass from 1.77.6 to 1.77.7 #40623
Open
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Edit: After the creation of this PR,
sass@1.77.8
has been released, but it doesn't change anything to this PR that still can be merged as is.)Description
When using
sass@1.77.7
, we have some warnings when runningnpm run css
. More info at Sass: Breaking Change: Mixed Declarations.If we simply move some calls to mixins in our code, the warnings are not displayed anymore. The related files are:
scss/_modal.scss
scss/_reboot.scss
scss/_type.scss
A simple way to measure the possible impact is to compare the built
bootstrap.css
from themain
branch, and this branch:As it can be seen here, there's no impact as the mixins don't apply values to some siblings CSS rules for the same selector, so the order here is not important and will produce the same CSS bundle in the end.
Target release
This change is retro-compatible as it works with
sass@1.77.6
too. However, if we want to help folks, we might envisage to merge this PR, and then maybe release a v5.3.4 rather quickly? What do you think @twbs/css-review?Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #40621