Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @navbarCollapseWidth instead of hard coded value for default desktop #5163

Closed
wants to merge 1 commit into from
Closed

Conversation

yberkholz
Copy link

Use @navbarCollapseWidth instead of hard coded value for DEFAULT DESKTOP in case of customized @navbarCollapseWidth

Use @navbarCollapseWidth instead of hard coded value for DEFAULT DESKTOP in case of customized @navbarCollapseWidth
@leeaston
Copy link

I like this, desktop is sometimes to early.

@mdo
Copy link
Member

mdo commented Sep 17, 2012

Resolved in 2.1.2-wip.

@mdo mdo closed this Sep 17, 2012
@yberkholz
Copy link
Author

I'm sorry, but I have to disagree! The problem wasn't resolved. Neither in the "2.1.2-wip" branch nor in the "master" branch.

If you may take a look at responsive-navbar.less line 169
That looks like a hardcoded value to me:
@media (min-width: 980px)

Default value of @navbarCollapseWidth equals 979px therfore the value of 980px seems related: @navbarCollapseWidth+1; Surely no coincidence.

BTW: Sorry for making pullrequest against master branch - haven't read the wiki :|

mdo added a commit that referenced this pull request Sep 17, 2012
stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants