New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.1 wip #7111

Merged
merged 11 commits into from Mar 1, 2013

Conversation

Projects
None yet
@fat
Member

fat commented Mar 1, 2013

No description provided.

fat added a commit that referenced this pull request Mar 1, 2013

@fat fat merged commit eb24718 into master Mar 1, 2013

1 check passed

default The Travis build passed
Details
@Yohn

This comment has been minimized.

Show comment
Hide comment
@Yohn

Yohn Mar 1, 2013

Contributor

👍 thanks for the bug fixes!

I just updated my current project and nothing broke so far lol
I did notice (I believe it was in the previous version to) that using selector: '[title]' for the tooltips wasnt working =/

Contributor

Yohn commented Mar 1, 2013

👍 thanks for the bug fixes!

I just updated my current project and nothing broke so far lol
I did notice (I believe it was in the previous version to) that using selector: '[title]' for the tooltips wasnt working =/

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 1, 2013

Member

Fixes #6835.

Member

cvrebert commented on 40b7a90 Mar 1, 2013

Fixes #6835.

This comment has been minimized.

Show comment
Hide comment
@rzhw

rzhw Mar 1, 2013

dropdown-menu is only being used as a CSS class instead of an event namespace, isn't it?

rzhw replied Mar 1, 2013

dropdown-menu is only being used as a CSS class instead of an event namespace, isn't it?

This comment has been minimized.

Show comment
Hide comment
@mitnal

mitnal Mar 7, 2013

this should be

.on('click.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })

Also see: http://api.jquery.com/on/

.on( events [, selector ] [, data ], handler(eventObject) )

mitnal replied Mar 7, 2013

this should be

.on('click.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })

Also see: http://api.jquery.com/on/

.on( events [, selector ] [, data ], handler(eventObject) )

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 7, 2013

Member

@mitnal: Awesome, open a pull request.

Member

cvrebert replied Mar 7, 2013

@mitnal: Awesome, open a pull request.

This comment has been minimized.

Show comment
Hide comment
@mitnal

mitnal Mar 7, 2013

@cvrebert will do as soon as I have time, perhaps on the weekend.

mitnal replied Mar 7, 2013

@cvrebert will do as soon as I have time, perhaps on the weekend.

This comment has been minimized.

Show comment
Hide comment
@mitnal

mitnal Mar 8, 2013

I opened a pull request against 3.0.0-wip (#7211), if needed I can also open one against master.

mitnal replied Mar 8, 2013

I opened a pull request against 3.0.0-wip (#7211), if needed I can also open one against master.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 1, 2013

Member

Fixes #6833.

Member

cvrebert commented on ef80765 Mar 1, 2013

Fixes #6833.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 1, 2013

Member

Fixes #6872.

Member

cvrebert commented on 839b0c8 Mar 1, 2013

Fixes #6872.

This comment has been minimized.

Show comment
Hide comment
@duellsy

duellsy Mar 13, 2013

I approved this commit message.

duellsy replied Mar 13, 2013

I approved this commit message.

This comment has been minimized.

Show comment
Hide comment
@tomconroy

tomconroy replied Mar 19, 2013

This comment has been minimized.

Show comment
Hide comment
@dontfeedthecode

dontfeedthecode replied Mar 19, 2013

Gold!

This comment has been minimized.

Show comment
Hide comment
@zenware

zenware Mar 24, 2013

I enjoy that twitter isn't too classy for accurate commit messages.

zenware replied Mar 24, 2013

I enjoy that twitter isn't too classy for accurate commit messages.

This comment has been minimized.

Show comment
Hide comment
@virtualjoker

virtualjoker May 10, 2013

Loved too this commit message!

virtualjoker replied May 10, 2013

Loved too this commit message!

This comment has been minimized.

Show comment
Hide comment
@xles

xles replied May 10, 2013

👍

This comment has been minimized.

Show comment
Hide comment
@avocade

avocade replied May 10, 2013

Wired.

This comment has been minimized.

Show comment
Hide comment
@jmserra

jmserra replied May 23, 2013

rofl

This comment has been minimized.

Show comment
Hide comment
@tjhorner

tjhorner Jul 22, 2013

Shiiiit indeed.

tjhorner replied Jul 22, 2013

Shiiiit indeed.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 1, 2013

Member

Fixes #7098 / a part of #7022.

Member

cvrebert commented on a61322c Mar 1, 2013

Fixes #7098 / a part of #7022.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Mar 1, 2013

Member

Fixes #6832.

Member

cvrebert commented on 01e0f8c Mar 1, 2013

Fixes #6832.

@andriijas

This comment has been minimized.

Show comment
Hide comment
@andriijas

andriijas Mar 1, 2013

Contributor

Thanks for cranking this one out @fat - hope you get the most wunderful weekend!

Contributor

andriijas commented Mar 1, 2013

Thanks for cranking this one out @fat - hope you get the most wunderful weekend!

@PHLAK

This comment has been minimized.

Show comment
Hide comment
@PHLAK

PHLAK Mar 1, 2013

Contributor

These are good fixes but those commit messages are terrible. At least try to be descriptive of the changes made.

Contributor

PHLAK commented Mar 1, 2013

These are good fixes but those commit messages are terrible. At least try to be descriptive of the changes made.

@LeEnno

This comment has been minimized.

Show comment
Hide comment
@LeEnno

LeEnno Mar 4, 2013

The last argument (this) breaks functionality for me. The key and value params become undefined within the function, so options stays empty. This leads to defaults overwriting this._options.

Deleting the last argument works for me.

LeEnno commented on docs/assets/js/bootstrap.js in 01e0f8c Mar 4, 2013

The last argument (this) breaks functionality for me. The key and value params become undefined within the function, so options stays empty. This leads to defaults overwriting this._options.

Deleting the last argument works for me.

@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Mar 7, 2013

Breaks middle mouse button on Firefox, see #7118.

msiemens commented on js/bootstrap-dropdown.js in 40b7a90 Mar 7, 2013

Breaks middle mouse button on Firefox, see #7118.

This comment has been minimized.

Show comment
Hide comment
@mitnal

mitnal Mar 7, 2013

I can confirm that this breaks the middle mouse button on Firefox. With the below proposed solution the middle mouse button works.

mitnal replied Mar 7, 2013

I can confirm that this breaks the middle mouse button on Firefox. With the below proposed solution the middle mouse button works.

This comment has been minimized.

Show comment
Hide comment
@mjvestal

mjvestal Mar 11, 2013

This also caused an out of memory exception in IE8 whenever something like this was called:
$(document).off('.some-other-namespace');

mjvestal replied Mar 11, 2013

This also caused an out of memory exception in IE8 whenever something like this was called:
$(document).off('.some-other-namespace');

This comment has been minimized.

Show comment
Hide comment
@mjvestal

mjvestal Mar 22, 2013

Should this be:
.on('click.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })

As is, clicking on empty space or in inputs closes the drop downs.

mjvestal replied Mar 22, 2013

Should this be:
.on('click.dropdown.data-api', '.dropdown-menu', function (e) { e.stopPropagation() })

As is, clicking on empty space or in inputs closes the drop downs.

This comment has been minimized.

Show comment
Hide comment
@mitnal

mitnal Mar 22, 2013

See below (40b7a90#commitcomment-2765332) and #7211.

@mjvestal Sorry didn't see your comment on the pull request.

mitnal replied Mar 22, 2013

See below (40b7a90#commitcomment-2765332) and #7211.

@mjvestal Sorry didn't see your comment on the pull request.

@tf25

This comment has been minimized.

Show comment
Hide comment
@tf25

tf25 Apr 20, 2013

Bootstrap don't open in new tab when click middle mouse button, how to fix it ?

tf25 commented Apr 20, 2013

Bootstrap don't open in new tab when click middle mouse button, how to fix it ?

@vandux

This comment has been minimized.

Show comment
Hide comment
@vandux

vandux Aug 8, 2014

why do you include "this" here?

vandux commented on docs/assets/js/bootstrap-tooltip.js in 01e0f8c Aug 8, 2014

why do you include "this" here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment