Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7213 Collapse plugin does not correctly set the "collapsed" class. #7424

Merged
merged 4 commits into from
Jun 28, 2013

Conversation

sody
Copy link
Contributor

@sody sody commented Mar 29, 2013

Collapse plugin does not correctly set the "collapsed" class on accordion heading links.
Patch includes fix and tests.

Before:
http://jsfiddle.net/uzSJD/6/

After:
http://jsfiddle.net/uzSJD/5/

@Hedde
Copy link

Hedde commented Apr 17, 2013

+1

@cvrebert
Copy link
Collaborator

Competing PR that also claims to fix #7213: #7243

@intellix
Copy link
Contributor

This doesn't work programmatically:

$('#body2').collapse('toggle');
$('#body2').collapse('hide');
$('#body2').collapse('show');

The arrows don't change through this. Shouldn't they be connected?

fat added a commit that referenced this pull request Jun 28, 2013
Fixes #7213 Collapse plugin does not correctly set the "collapsed" class.
@fat fat merged commit d23800c into twbs:3.0.0-wip Jun 28, 2013
@fat
Copy link
Member

fat commented Jun 28, 2013

cool - thanks for the tests

@vyruz1986
Copy link

What about @intellix 's comment about the programatic toggling? In bootstrap 3.2.0 this doesn't seem to be working: http://jsfiddle.net/6f6g536r/2/

@hnrch02
Copy link
Collaborator

hnrch02 commented Sep 16, 2014

@vyruz1986 See #13636.

@twbs twbs locked and limited conversation to collaborators Sep 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants