Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about the license change from Apache to MIT #9075

Closed
wants to merge 28 commits into from
Closed

Note about the license change from Apache to MIT #9075

wants to merge 28 commits into from

Conversation

marclaporte
Copy link

Re: #2054

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 4, 2013

I think "remove" sounds kinda harsh; maybe "replace" or "rewrite" instead?

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 4, 2013

The MIT License mention in CONTRIBUTING should be hyperlinked, like the ASLv2 was.

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 4, 2013

This would also be a logistical pain in the neck regarding dealing with outstanding pull requests that were opened before the switch.

@Flydiverny
Copy link
Contributor

I suppose one way would be to have them all closed and resubmitted?

@marclaporte
Copy link
Author

@cvrebert: OK for "replace" or "rewrite" -> done
@cvrebert: As for link to MIT: -> done
@cvrebert @Flydiverny : Yes, for existing pull requests and ongoing commits: it's a pain which is why we need to stop flow ASAP. Maybe just add a comment to each asking if it's OK that it be under MIT license?

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2013

I think the license switch would be at least a 2-step process (1. all new commits are under MIT; 2. relicense everything to MIT once we have all old committers' permission & any rewriting is complete), and these newer commits are mixing steps.

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2013

That, and Jesus don't do 1 commit per file.

@marclaporte
Copy link
Author

@cvrebert Using the web interface, don't know how to package all in one commit via the web. Do you want me to cancel the PR and start over?

@rhodrykorb
Copy link
Contributor

Made change to MIT from Apache on all (most) files #9094

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2013

Closing in favor of #9094.

@cvrebert cvrebert closed this Aug 5, 2013
@rhodrykorb
Copy link
Contributor

Updated #9096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants