New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HTML5 validation of docs pages to the build #9396

Merged
merged 6 commits into from Aug 13, 2013

Conversation

Projects
None yet
2 participants
@cvrebert
Member

cvrebert commented Aug 12, 2013

This works, but shouldn't be merged until the docs are fixed to actually pass validation. and the docs now validate!
This PR is also a feeler for whether @mdo would be interested in this.

Note: grunt-html-validation is slightly broken in that it doesn't fail the build when validation fails; but it works fine otherwise.

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 12, 2013

Member

Not opposed to it, but I'm curious how fucked the docs currently are to see if this is feasible/maintainable 😆.

Member

mdo commented Aug 12, 2013

Not opposed to it, but I'm curious how fucked the docs currently are to see if this is feasible/maintainable 😆.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 12, 2013

Member

Well, the Travis build runs now, so you can take a look-see.

Member

cvrebert commented Aug 12, 2013

Well, the Travis build runs now, so you can take a look-see.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 12, 2013

Member

It's mostly the <iframe>s for the GitHub buttons, and the placeholder <img>s lacking src & alt. Pretty minor stuff otherwise.

Member

cvrebert commented Aug 12, 2013

It's mostly the <iframe>s for the GitHub buttons, and the placeholder <img>s lacking src & alt. Pretty minor stuff otherwise.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 13, 2013

Member

Validity fixes moved to #9399.

Member

cvrebert commented Aug 13, 2013

Validity fixes moved to #9399.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 13, 2013

Member

@mdo Only remaining errors are ARIA stuff and <img>s-without-src:
https://travis-ci.org/twbs/bootstrap/builds/10138466

Member

cvrebert commented Aug 13, 2013

@mdo Only remaining errors are ARIA stuff and <img>s-without-src:
https://travis-ci.org/twbs/bootstrap/builds/10138466

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 13, 2013

Member

@mdo The docs fully validate now! Should be good to merge at your leisure/command.

Member

cvrebert commented Aug 13, 2013

@mdo The docs fully validate now! Should be good to merge at your leisure/command.

mdo added a commit that referenced this pull request Aug 13, 2013

Merge pull request #9396 from twbs/docs-html-validation
add HTML5 validation of docs pages to the build

@mdo mdo merged commit 8aecfb4 into 3.0.0-wip Aug 13, 2013

1 check passed

default The Travis CI build passed
Details

@mdo mdo deleted the docs-html-validation branch Aug 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment