Bump bootstrap to v5.3.0 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-bump-bootstrap-to-v5.3.0-stable
branch
from
d4da9e3
to
e41d2ba
Compare
|
Closed the dependabot bootstrap PRs, this needs a rebase. |
julien-deramond
force-pushed
the
main-jd-bump-bootstrap-to-v5.3.0-stable
branch
from
fa79a8c
to
7c644be
Compare
julien-deramond
force-pushed
the
main-jd-bump-bootstrap-to-v5.3.0-stable
branch
from
c980013
to
1303794
Compare
XhmikosR
reviewed
Jun 15, 2023
| @@ -362,7 +362,7 @@ | |||
| } | |||
| ], | |||
| "peerDependencies": { | |||
| "@popperjs/core": "^2.11.6" | |||
| "@popperjs/core": "^2.11.7" | |||
There was a problem hiding this comment.
Any instances of popperjs should point to 2.11.8 now
There was a problem hiding this comment.
Yep, saw the changes, I'll update this PR asap to bump the remaining things to 2.11.8.
FYI we have leftovers in Bootstrap of Popper v2.11.7: https://github.com/twbs/bootstrap/blob/2f617215755b066904248525a8c56ea425dde871/package.json#L181 and https://github.com/twbs/bootstrap/blob/2f617215755b066904248525a8c56ea425dde871/package.json#L103 (modifié)
There was a problem hiding this comment.
Actually wait, if this is what we get with npm i, then it's fine.
XhmikosR
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to bump "bootstrap" dependency to v5.3.0 now that the stable release is available to everyone.
color-modesdirectory, which is handled in #184.For most sub-directories, bumped "bootstrap" to v5.3.0. For some of them, it was enough, for others, it required some additional changes.
For
sass-js-esm:index.htmlis updated to use the new CDN links (even for@popperjs/core).variables-dark.scssimport to fix Sass compilation.For
sass-js,vite,vue,parcel, andwebpack:variables-dark.scssimport to fix Sass compilation.For
starter:index.htmlis updated to use the new CDN links and integrity values.On top of that, I've updated the /5.2 links to /5.3 via fa79a8c