Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent icons from font #1521

Merged
merged 7 commits into from
Mar 25, 2023
Merged

Remove non-existent icons from font #1521

merged 7 commits into from
Mar 25, 2023

Conversation

stefan-korn
Copy link
Contributor

@stefan-korn stefan-korn commented Nov 28, 2022

It seems there are some invalid icon codes, anything like *-circle-1 and *-circle-fill-1. Should they be removed?

Fixes #1639

Copy link

@Alex-Toucan Alex-Toucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right, with the invalid icons not existing.

@XhmikosR
Copy link
Member

The icons are there, it's just something is going wrong with fantasticon.

@mdo
Copy link
Member

mdo commented Nov 30, 2022

Oh these look like duplicates. Those can probably get removed as suggested. I'll have to take a closer look.

@XhmikosR
Copy link
Member

They cannot be removed because they are added again by fantasticon...

@XhmikosR
Copy link
Member

XhmikosR commented Nov 30, 2022

I believe it's a bug in fantasticon that gets it confused because we have the same suffix or something like that.

BTW fantasticon v2.0.0 is completely broken on Windows: tancredi/fantasticon#470

Might be worth trying to rename the individual SVG files to see if the issue is fixed.

@mdo
Copy link
Member

mdo commented Dec 27, 2022

Yeah, these returned after removing them, so it's fantasticon is adding them back. Upgrading locally to v2.0.0 didn't help anything, so this might have to wait until we go v2 to do a rename of the icons.

@mdo mdo added the someday Won't implement in current major version, but maybe the next one! label Dec 27, 2022
@XhmikosR
Copy link
Member

I made some progress here identifying the root cause. It seems the problem comes from using the previous codepoints. If I create the codepoints from start, then they are unique and as many as the icons.

I'll make a new issue, but removing these is moot unless fantasticon is fixed.

@XhmikosR
Copy link
Member

Actually wait, this is the root cause.

@XhmikosR XhmikosR reopened this Mar 25, 2023
@XhmikosR XhmikosR added build and removed someday Won't implement in current major version, but maybe the next one! labels Mar 25, 2023
@XhmikosR
Copy link
Member

It seems there are more unused icons. I'll try to update your branch @stefan-korn but if you could do it that'd be awesome.

PS. Please don't commit the generated files; we only need the changes in bootstrap-icons.json in this PR.

@XhmikosR XhmikosR changed the title Remove invalid circle-1 icons Remove non-existent icons from font Mar 25, 2023
@XhmikosR
Copy link
Member

OK, I think I cleaned all of the non-existent icons. Would be nice if we had some kind of script to check for this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Duplicate generated icons
4 participants