-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-existent icons from font #1521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems about right, with the invalid icons not existing.
The icons are there, it's just something is going wrong with fantasticon. |
Oh these look like duplicates. Those can probably get removed as suggested. I'll have to take a closer look. |
They cannot be removed because they are added again by fantasticon... |
I believe it's a bug in fantasticon that gets it confused because we have the same suffix or something like that. BTW fantasticon v2.0.0 is completely broken on Windows: tancredi/fantasticon#470 Might be worth trying to rename the individual SVG files to see if the issue is fixed. |
Yeah, these returned after removing them, so it's fantasticon is adding them back. Upgrading locally to v2.0.0 didn't help anything, so this might have to wait until we go v2 to do a rename of the icons. |
I made some progress here identifying the root cause. It seems the problem comes from using the previous codepoints. If I create the codepoints from start, then they are unique and as many as the icons. I'll make a new issue, but removing these is moot unless fantasticon is fixed. |
Actually wait, this is the root cause. |
It seems there are more unused icons. I'll try to update your branch @stefan-korn but if you could do it that'd be awesome. PS. Please don't commit the generated files; we only need the changes in bootstrap-icons.json in this PR. |
OK, I think I cleaned all of the non-existent icons. Would be nice if we had some kind of script to check for this in the future. |
It seems there are some invalid icon codes, anything like *-circle-1 and *-circle-fill-1. Should they be removed?
Fixes #1639