Fix SVGO distortions #213
Merged
Fix SVGO distortions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVGO options had to change in order to preserve an SVG's design and editability in other apps. Previously all icons rendered fine in browser, in macOS quick look, and in Figma, but not when opening directly in Sketch and Illustrator.
Closed
|
I am still noticing distortions when using the SVGs in Sketch. Not sure if I'm missing something.
|
|
Hmm, yeah I think this is because we declare the width/height as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210.
According to svg/svgo#1164, some SVG renderers cannot display images correctly without a couple of configuration changes. This PR implements those changes and re-processes all the icons once more. Verified on a few icons with Sketch and Illustrator that they now open properly.