Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sprite generation and docs #262

Closed
wants to merge 1 commit into from

Conversation

bastienmoulia
Copy link
Contributor

Relative to #215

@XhmikosR
Copy link
Member

XhmikosR commented May 26, 2020

I'm so and so on this. The resulting SVG is unoptimized. Also, I'm not sure why we need it to be in the repo root for the docs.

@mdo
Copy link
Member

mdo commented May 28, 2020

I'm very into this! Sprite generation and including the icons via that sounds amazing. I think we'll want to provide some options and documentation on how to optimize this by including a subset of icons. I've started playing with this locally and have some more thoughts and changes planned. Will share soon!

@mdo mdo mentioned this pull request May 29, 2020
@mdo
Copy link
Member

mdo commented May 29, 2020

Building on top of this in #274.

@mdo mdo closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants