Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) #89

Closed
wants to merge 3 commits into from

Conversation

tmorehouse
Copy link

@tmorehouse tmorehouse commented Dec 18, 2019

Fixes the names of the skip-* icons, as well as replaces occurrences of stroke="#000" with stroke="currentColor" (in skip icons and text-right icon).

Fixes #84

cc/ @mdo

Before:

image

image

After:

image

image

@tmorehouse tmorehouse changed the title fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) Dec 18, 2019
@tmorehouse tmorehouse changed the title fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) Dec 18, 2019
@tmorehouse tmorehouse changed the title fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) fix: skip-* icon names and replace stroke="#000" with stroke="currentColor" (fixes #84) Dec 18, 2019
@mdo
Copy link
Member

mdo commented Dec 18, 2019

This was an error on my part before export—these shouldn't be strokes at all. Made the decision awhile a go to go with a fill only approach, which means outlined shapes vs stroked paths.

@tmorehouse
Copy link
Author

tmorehouse commented Dec 18, 2019

The stroke="#000" (non outlined shape) only appears in the fill versions of the skip icons, and text right icon.

The skip names were an issue (definitely mixed up). But perhaps backward/start should be swapped and forward/end should be swapped? It depends on if using in a video/audio context or a pagination context I guess (I was thinking in pagination terms, i.e. prev/next vs start/end)

This was referenced Mar 8, 2020
@mdo
Copy link
Member

mdo commented Mar 8, 2020

Thanks for reporting and doing this! I had to fix this in Figma, too, so I ended up doing a fresh export and fixed it in another PR. See #138 and #139. Thanks again!

@mdo mdo closed this Mar 8, 2020
@tmorehouse
Copy link
Author

No problem! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] skip-* icon names/svgs are mixed up, and also have hardcoded stroke color of black
2 participants