Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split border-width into separate variable #644

Merged
merged 1 commit into from
Feb 9, 2015

Conversation

mhuggins
Copy link
Contributor

In order to override some content spacing based upon header/footer bars, it was necessary to take border-width into account during other sass calculations. Splitting it into a variable improves readability instead of having code like:

.content {
    margin-bottom: ($bar-base-height + ($bar-side-spacing + 1) * 2);  // adding 1 for $border-default's border-width
}

I can now use code like:

.content {
    margin-bottom: ($bar-base-height + ($bar-side-spacing + $border-default-width) * 2);
}

@cvrebert cvrebert added the css label Aug 14, 2014
XhmikosR added a commit that referenced this pull request Feb 9, 2015
Split border-width into separate variable
@XhmikosR XhmikosR merged commit b49cc53 into twbs:master Feb 9, 2015
@XhmikosR XhmikosR added this to the 2.1.0 milestone Feb 9, 2015
@mhuggins mhuggins deleted the border-width-variable branch February 23, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants