New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify modal selector in data attribute with backward compatibility. #767

Closed

XhmikosR wants to merge 1 commit into master from juriejan-modal-selector-attribute

Member

XhmikosR commented Apr 23, 2015

Fixes #682.

Instead of hijacking the href attribute of an anchor tag to indicate a selector of a modal that we'd like to display on it being clicked. We can rather make use of a data-modal attribute to indicate the selector of the desired modal.

This is the same as #730, rebased and squashed.


          Specify modal selector in data attribute with backward compatibility.

e2cf27c

XhmikosR added the js label

XhmikosR mentioned this pull request

Specify modal selector in data attribute #730

Closed

XhmikosR force-pushed the master branch from 1c7d2fa to 7d7ef88 Compare

August 20, 2015 15:08

rainchen commented Mar 24, 2016

+1

XhmikosR closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment