Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jasmine version #819

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Bump Jasmine version #819

merged 1 commit into from
Mar 6, 2016

Conversation

Johann-S
Copy link
Member

I updated package.json but they are some warnings when I run grunt jasmine

@XhmikosR

@XhmikosR
Copy link
Member

The whole idea was to not have those :P

But currently we are having another error due to clean, also on Bootstrap.

@Johann-S
Copy link
Member Author

Yes exactly what I want to do 😄
and I'll work on it .

@XhmikosR
Copy link
Member

So, apparently the clean error happens only on 5.7.0. Trying to figure out the cause, and report it.

@Johann-S
Copy link
Member Author

Maybe I can do the same as : twbs/bootstrap#19331 ?

@XhmikosR
Copy link
Member

It's just a workaround, 5.7.1 should be out next week.

XhmikosR added a commit that referenced this pull request Mar 6, 2016
@XhmikosR XhmikosR merged commit b98f88b into twbs:master Mar 6, 2016
@XhmikosR
Copy link
Member

XhmikosR commented Mar 7, 2016

@Johann-S: see if we have those warnings fixed and please CC me.

@Johann-S
Copy link
Member Author

Johann-S commented Mar 7, 2016

No still present : https://travis-ci.org/twbs/ratchet/jobs/113992956

They had so many changes between the two versions 0.9.2 and 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants