Have Savage also set GitHub build status #11
Comments
I haven't worked with Scala before, would you be interested in having me give this a shot though? It seems similar to Java which isn't bad. |
If you want to, I won't stop you. Should basically involve calling this method: https://github.com/eclipse/egit-github/blob/master/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/service/CommitService.java#L403 |
OK. Thanks @cvrebert. I just wanted to check as I've had some people / projects who aren't interested and were rather mean when someone new to a language attempted a PR. Just want to help not be a bother 😃 Just for notes for myself, the function requires: IRepositoryIdProvider repository = 'twbs/bootstrap'; String sha = 'pull request\'s SHA value' CommitStatus status = ['Pending', 'Failed', 'Success'] |
This is currently soft-blocked on |
With much thanks to Matthias Sohn, the blocker has now shifted to https://bugs.eclipse.org/bugs/show_bug.cgi?id=454237 |
@kkirsche I landed an implementation of this on |
Thanks to http://dev.eclipse.org/mhonarc/lists/egit-dev/msg03810.html / ddbf069, this should now be unblocked. |
Haha no worries. You were probably going to make a better quality version than my first pass simply due to familiarity with the codebase. I'm always happy to help though and I always appreciate the twbs's kindness during reviews. 😃 |
Currently in final phase of production testing: twbs/bootstrap#16352 |
Test was successful! |
https://github.com/blog/1935-see-results-from-all-pull-request-status-checks
The text was updated successfully, but these errors were encountered: