Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Stylelint 16.0.2 and switch to @stylistic/stylelint-plugin #236

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 19, 2023

BREAKING CHANGES:

  • requires Node.js 18.12.0 due to upstream requirements
  • switched from the deprecated to stylelint-codeguide so you may need to adapt any custom overrides/rules (stylistic -> codeguide prefix)

Closes #232

TODO:

  • Adapt branch protection rules before the merge

@tagliala
Copy link

tagliala commented Dec 19, 2023

@XhmikosR please take a look at tagliala#1 (comment), stylelint-codeguide is changing its name

BTW I'm going to submit a PR here when everything is ready

@XhmikosR
Copy link
Member Author

Yeah, I know but I'm waiting for stylelint-stylistic/stylelint-stylistic#9 too

@tagliala
Copy link

tagliala commented Dec 19, 2023

Thanks, I will not submit and not update my PR

package.json Show resolved Hide resolved
@weihongyu12
Copy link

stylelint-codeguide has been deprecated, use @stylistic/stylelint-plugin instead?

@XhmikosR
Copy link
Member Author

The PR is draft, I'll adapt it, but I'm still waiting for a config from their side.

BREAKING CHANGES:

* requires Node.js 18.12.0 due to upstream requirements
* switched from the deprecated to stylelint-codeguide so you may need to adapt any custom overrides/rules (stylistic -> @Stylistic prefix)
@XhmikosR XhmikosR changed the title Update to Stylelint 16.0.2 and switch to stylelint-codeguide Update to Stylelint 16.0.2 and switch to @stylistic/stylelint-plugin Dec 23, 2023
@XhmikosR XhmikosR marked this pull request as ready for review December 23, 2023 15:50
@XhmikosR XhmikosR merged commit d208a47 into main Dec 23, 2023
4 checks passed
@XhmikosR XhmikosR deleted the xmr/deps branch December 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage of stylelint 16.0
3 participants