New rules #70
New rules #70
Conversation
I'm fine either way.
Not supported by Libsass (https://sass-lang.com/documentation/modules/color)
Doesn't look relevant imo
For some cases, it might be interesting, but for others like this, we will lose the ability to combine comlex selectors:
Agreed
Nope, it's even required for colors Dart Sass |
I think I'm gonna drop these 2 and just leave it as is since it works both ways AFAICT. OK about the rest. I will rebase this branch with the final rules, and we fix any issues in the upstream https://github.com/twbs/bootstrap/compare/master-xmr-scss-rules and we make a PR. |
scss/index.js
Outdated
| 'scss/dollar-variable-colon-space-after': 'at-least-one-space', | ||
| 'scss/dollar-variable-colon-space-before': 'never', | ||
| 'scss/dollar-variable-no-missing-interpolation': true, | ||
| 'scss/dollar-variable-pattern': '^[a-z][a-z-\\d]*$', | ||
| 'scss/map-keys-quotes': null, // This doesn't work well yet |
There was a problem hiding this comment.
What does This doesn't work well yet mean?
There was a problem hiding this comment.
IIRC we had some false positives last time I tried it hence why I disabled it.
* scss/at-import-partial-extension * scss/dimension-no-non-numeric-values * scss/selector-no-redundant-nesting-selector
Not sure if we should disable these:
scss/function-quote-no-quoted-strings-insideDroppedscss/function-unquote-no-unquoted-strings-insideDroppedAnd also if we should enable any of these here or upstream:
scss/function-color-relative: haven't tested itscss/partial-no-import: haven't tested itscss/selector-nest-combinators: this results in a lot of errors, so it might not be worth itBTW It might be a good chance to enable map-keys-quotes since there's an issue about it already (#35). It shouldn't be considered a BC anyway in core, right?
EDIT: upstream branch which I test here against: https://github.com/twbs/bootstrap/compare/master-xmr-scss-rules
TODO: