Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly named version? #18

Closed
akwok opened this issue Jan 12, 2017 · 7 comments
Closed

Strongly named version? #18

akwok opened this issue Jan 12, 2017 · 7 comments

Comments

@akwok
Copy link

akwok commented Jan 12, 2017

Love the package but are there any plans to release a strong named version in the near future? Our project is strong named (due to upstream requirements) and we are unable to consume this unless it's also strong named.

I am aware of workarounds such as signing the assembly ourselves (or forking the project), but am hoping for something cleaner and less intrusive.

Thanks!

@Sternerson
Copy link

Seconding this. We are using a disassembly-reassembly step to sign the dll. Sort of breaks the nuget magic.

@caesay
Copy link
Contributor

caesay commented Jan 25, 2017

There's no need for a him to provide a signed version of the assembly and i seriously disagree with this. There are many tools which facilitate the automatic signing of nuget dependencies, some of which can also be consumed as a nuget package. No need for any manual steps. Once such tool is this: https://github.com/brutaldev/StrongNameSigner

Providing a signed version becomes much more of a problem - here is an example from personal experience: StackExchange.Redis, they offer both a regular and a strongly signed assembly, and other nuget packages choose which one to use seemingly at random. This means if you consume two other nuget packages, you might end up with SignalR which requires the StrongName version, and Hangfire which requires the unsigned version.

@frankshearar
Copy link

No one should ever publish both a signed and unsigned version of an assembly. They don't have the same name, so bindingRedirect doesn't work (or you have to bindingRedirect BOTH, and then you have a duplicate dependency on essentially the same package...).

But publishing an unsigned package makes it painful for those who have no choice but to sign their stuff. Yes, that's the consumer's problem, not the publisher's problem. But publishers should care very deeply about their consumers' problems.

@caesay
Copy link
Contributor

caesay commented Feb 22, 2017

Fwiw you can also take a look here for a nuget-only solution to this problem:
https://github.com/dsplaisted/strongnamer

@frankshearar
Copy link

Yep, StrongNamer is why I'm here :) It's great, and does what it says on the tin, but if A is not strong named, and B is, and C uses B... C also needs to use StrongNamer, to sign A.

Anyway, we have come up with an alternate plan.

@aidanbebbington
Copy link
Collaborator

I'm afraid I'm out of the .NET space right now, and the controversy around this one seems to just keep swirling, so I'm not sure I know enough to proceed. If someone's keen enough to whip up a pull request then I'll certainly take a look at it.

@twcclegg
Copy link
Owner

octokit/octokit.net#405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants