Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An issue with inter-package re-exports #1037

Closed
mrkkrp opened this issue May 24, 2023 · 0 comments · Fixed by #1039
Closed

An issue with inter-package re-exports #1037

mrkkrp opened this issue May 24, 2023 · 0 comments · Fixed by #1039
Labels
bug Something isn't working

Comments

@mrkkrp
Copy link
Member

mrkkrp commented May 24, 2023

When a module re-exports another module from a different package and that package is not specified as a direct dependency of the component we are formatting we are likely going to get incorrect fixity information because the set of packages from which that information is drawn is restricted before re-exports are taken into consideration.

Possible solution:

  • Equip re-export targets also with package names. This was my original design where both the exporting module and the exported modules were fully qualified, i.e. with package names, but that introduced quite a bit of complexity and this corner case did not come to my mind, so I simplified the design.
  • Over-approximate the set of packages we need by including all packages that can be re-export targets. This is simple and should not have any adverse side-effects because the actual fixity resolution process is controlled by the imports. Restricting the package set is only an optimization measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant