Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-idempotence with comment in tuple or paren #450

Closed
judah opened this issue Nov 4, 2019 · 0 comments · Fixed by #573
Closed

Non-idempotence with comment in tuple or paren #450

judah opened this issue Nov 4, 2019 · 0 comments · Fixed by #573
Assignees
@mrkkrp
Labels
bug Something isn't working comments Issues related to comment placement idempotence Idempotence issues and solutions.
Projects
Google engagement

Comments

@judah
Copy link

judah commented Nov 4, 2019

Input:

x = ({-a-}b, c)

Error:

Formatting is not idempotent:
  before: "x = (\n  {-a-} b)\n"
  after:  "x =\n  ( {-a-} b\n  )\n"

This also happens with a simple parenthesis:

x = ({-a-}b)

Results in:

Formatting is not idempotent:
  before: "x = (\n  {-a-} b)\n"
  after:  "x =\n  ( {-a-} b\n  )\n"
@mrkkrp mrkkrp added bug Something isn't working idempotence Idempotence issues and solutions. labels Nov 4, 2019
@mrkkrp mrkkrp added this to Easy in Google engagement Apr 9, 2020
@mrkkrp mrkkrp added the comments Issues related to comment placement label Apr 9, 2020
@mrkkrp mrkkrp moved this from Backlog to In progress in Google engagement Apr 26, 2020
@mrkkrp mrkkrp self-assigned this Apr 26, 2020
@mrkkrp mrkkrp mentioned this issue Apr 28, 2020
Merged
@mrkkrp mrkkrp moved this from In progress to Done in Google engagement Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrkkrp mrkkrp

Labels
bug Something isn't working comments Issues related to comment placement idempotence Idempotence issues and solutions.
Projects
No open projects
Google engagement
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix non-idempotence with comment in tuple or paren tweag/ormolu
2 participants
@judah @mrkkrp