feat: switch to nickel for configuration #703
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, this removes the collation mode. We will support a subset of the collation mode using Nickel's merge functionality.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
languages.ncl
Issue: #634
Note
This PR is blocked until a new
nickel-lang-coreversion is released to crates.io (we don't want to depend on a git crate fortopiary-config. See: tweag/nickel#1900Description
To support Nickel adoption, this PR switches Topiary's configuration from TOML to Nickel.
Unfortunately, this removes the collation mode.
We will support a subset of the collation mode using Nickel's merge functionality.
NOTE: Even with nickel's default features disabled, compilation of Topiary is increased by about five-fold with this PR. Don't worry if compilation suddenly takes much longer.
Checklist
Checklist before merging: