Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to see whether an item can fit on a page at all #51

Closed
diondokter opened this issue Apr 30, 2024 · 0 comments · Fixed by #53
Closed

Add check to see whether an item can fit on a page at all #51

diondokter opened this issue Apr 30, 2024 · 0 comments · Fixed by #53

Comments

@diondokter
Copy link
Collaborator

This example:
https://github.com/cr1901/miniconf-sample/tree/main

The pages are only 16 bytes, so the given data doesn't fit. But it won't ever fit.
Currently the crate concludes that the storage must be full. However, with an extra check this error can be improved.

Might also be worth it to document the overheads a little bit like the page states and the item header size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant