Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided a bower main dependency for an easy integration #171

Merged
merged 2 commits into from Mar 25, 2015

Conversation

azachar
Copy link
Contributor

@azachar azachar commented Nov 8, 2014

Hello!
I have created the bower.json file with specified the main dependency so it can be used in a bower environment without tweeking.

The main dependency is set to src/Tween.js (if you wish to changed, feel free to do it).

Best regards,
Andrej

@lynndylanhurley
Copy link

+1

I'd like to use this with rails-assets, but it's not possible without the bower.json file.

@sole
Copy link
Member

sole commented Mar 13, 2015

Hi @azachar, thanks for the pull request!

We changed the repository recently. Would you mind updating the url to point to tweenjs/tween.js instead of sole/tween.js?

Also the list of authors does not represent the actual people who've worked on it, but what's the usual bower style? List everyone who's contributed?

@azachar
Copy link
Contributor Author

azachar commented Mar 22, 2015

Hello @sole!

  1. I will change the repo url to tweenjs/tween.js
  2. The best is to mention everyone who contributed at least as a courtesy :)

Cheers,
Andrej

Updated the current home page url
@sole
Copy link
Member

sole commented Mar 25, 2015

Thanks Andrej!

I'll merge it for now, I will add a "add tween.js authors + contributors link" bug so we point people to the full list of people who've contributed :-)

sole added a commit that referenced this pull request Mar 25, 2015
Provided a bower main dependency for an easy integration
@sole sole merged commit 38f6eb2 into tweenjs:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants