Tween nested object #366
Tween nested object #366
Conversation
|
I think this is a great feature. I will review it soon.
…On Wed, Aug 30, 2017 at 12:26 PM Tyler Larson ***@***.***> wrote:
There didn't seem to be enough love for #313
<#313> to get it merged in. To
move the ball forward I made a version based on the suggestion by
@mikebolt <https://github.com/mikebolt> to make this work without the
string interpolation.
The performance impact should be a single function call for each level of
nesting.
------------------------------
You can view, comment on, or merge this pull request online at:
#366
Commit Summary
- adding tween nested object
File Changes
- *M* docs/user_guide.md
<https://github.com/tweenjs/tween.js/pull/366/files#diff-0> (15)
- *A* package-lock.json
<https://github.com/tweenjs/tween.js/pull/366/files#diff-1> (5400)
- *M* src/Tween.js
<https://github.com/tweenjs/tween.js/pull/366/files#diff-2> (152)
- *M* test/unit/tests.js
<https://github.com/tweenjs/tween.js/pull/366/files#diff-3> (75)
Patch Links:
- https://github.com/tweenjs/tween.js/pull/366.patch
- https://github.com/tweenjs/tween.js/pull/366.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#366>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACCav4bfM2Nx3N714BfAcL4eE56R6nJ5ks5sdbdOgaJpZM4PH3Dn>
.
|
|
Have you checked es6-tween? It uses my module called InterTween that does thing for your. Interpolates everything, just pass elapsed/value. Maybe es6-tween would be your choice? |
|
I like Tween.js and I would love to get this PR merged, but I will look more at es6-tween |
|
I like this idea too. From a basic skim, it looks good. Need to review one more time in more depth. |
docs/user_guide.md
Outdated
| @@ -390,6 +390,16 @@ relativeTween.start(); // Makes x go to -100 +100 = 0 | |||
|
|
|||
| Check [09_relative_values](../examples/09_relative_values.html) for an example. | |||
|
|
|||
| ### Tweening nested object | |||
|
|
|||
| Tween.js can also change properties across nested object. For example: | |||
There was a problem hiding this comment.
across a nested object or across nested objects
|
Is this dead on the water? |
|
Sorry for the delays! I would like to get things rolling. Tracking this in the new pull request tracking board: https://github.com/tweenjs/tween.js/projects/4 I'd like to set up GitHub Actions next to get automated tests running again, so we can more easily test pull request changes and get them merged! |
There was a problem hiding this comment.
This is very similar to #520. Let's consolidate into one PR. I suppose we need to close one of them. We can get both authors into the commit.
Also please keep the same structure as Tween.js without refactoring things out to new functions, so the change is clear, and keep refactors for separate PRs (unless necessary). The simpler the PR, the better.
|
Moved to #539 and merged. Thank you for this nice feature! |
There didn't seem to be enough love for #313 to get it merged in. To move the ball forward I made a version based on the suggestion by @mikebolt to make this work without the string interpolation.
The performance impact should be a single function call for each level of nesting.