Fix CJS entry point #659
Merged
Fix CJS entry point #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unable to import TWEEN with typescript, whatsoever. |
Closed
Closed
23 tasks
SilkePilon
added a commit
to SilkePilon/prismarine-viewer
that referenced
this pull request
Dec 19, 2023
this is no permanent fix as is nice to have a package up-to-date but for now until tweenjs/tween.js#659 is merged it works
|
this needs to be merged rn..... |
rom1504
pushed a commit
to PrismarineJS/prismarine-viewer
that referenced
this pull request
Dec 19, 2023
* Roll back tweenjs to 18.6.4 this is no permanent fix as is nice to have a package up-to-date but for now until tweenjs/tween.js#659 is merged it works * update to the latest working version (19.0.0)
|
Yep, the naming needed to be changed. I added an example Node.js CommonJS project in Thanks! Merged! |
|
Release in v22.0.0 (major versio bump because the file name changed, just in case anyone somehow relied on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649