Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IncompleteRead error in Stream #237

Closed
mihneagiurgea opened this issue Jan 17, 2013 · 3 comments
Closed

Handle IncompleteRead error in Stream #237

mihneagiurgea opened this issue Jan 17, 2013 · 3 comments
Labels
Bug This is regarding a bug with the library
Milestone
4.0

Comments

@mihneagiurgea
Copy link

The retry logic does not always work, because the try/except block does not catch all possible errors (sometimes resp.read() can throw IncompleteRead errors, in which case the request is not retried).
@tewalds tewalds mentioned this issue Oct 22, 2014
Merged
benfei pushed a commit to benfei/tweepy that referenced this issue Oct 16, 2016
BUG: handle IncompleteRead exceptions
a349d52 
This should handle both cases of incomplete read catched by requests, or
catched by tweepy.

This resolves tweepy#237, resolves tweepy#448, resolves tweepy#536, resolves tweepy#650,
resolves tweepy#691, resolves tweepy#798.

Similar to tweepy#498.
@Harmon758
Copy link
Member

Harmon758 commented Apr 26, 2019 •
edited

This seems to have been fixed with fae9091 (#498), but was reverted with 34af675, due to #501.

For discussion on the cause of this issue and how to handle it, see #448 and these Stack Overflow posts:
https://stackoverflow.com/q/26638329/6191255
https://stackoverflow.com/q/53326879/6191255
https://stackoverflow.com/q/48034725/6191255
https://stackoverflow.com/q/28717249/6191255

The error seems to be indicative of a full buffer disconnect. For reference:
https://developer.twitter.com/en/docs/tutorials/consuming-streaming-data
https://developer.twitter.com/en/docs/tweets/filter-realtime/guides/disconnections-explained
https://developer.twitter.com/en/docs/tweets/filter-realtime/guides/connecting

@Harmon758 Harmon758 added the Bug This is regarding a bug with the library label Apr 26, 2019
@Harmon758 Harmon758 changed the title Retry logic doesn't always work Handle IncompleteRead error in Stream Apr 26, 2019
This was referenced Apr 26, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Harmon758 Harmon758 mentioned this issue Oct 13, 2019
Closed
@msaby msaby mentioned this issue Mar 26, 2020
Open
@Kydlaw Kydlaw mentioned this issue Apr 7, 2020
Open
@fahadshery

This comment has been minimized.

Sign in to view
@Suryakumar007

This comment has been minimized.

Sign in to view
@eduardoltorres eduardoltorres mentioned this issue Sep 28, 2020
Open
@Harmon758 Harmon758 added this to the 4.0 milestone Jan 19, 2021
@YusukeSuzuki1213 YusukeSuzuki1213 mentioned this issue Jan 23, 2021
Closed
@Harmon758 Harmon758 mentioned this issue Apr 4, 2021
Closed
@Harmon758 Harmon758 mentioned this issue Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This is regarding a bug with the library
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@mihneagiurgea @fahadshery @Harmon758 @Suryakumar007