Allow optionally setting daemon flag on async threads. #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh I see this PR already existed: #268 |
|
What if it was added as an option which could be passed to the functions which start async threads? |
mmontagna
changed the title
|
Yeah I think adding this as an option makes sense. How about we pass it to the "options" object the constructor receives? Then you can just assign it to |
# The first commit's message is: Set daemon flag on async threads. # The 2nd commit message will be skipped: # Allow optionally setting thread's daemon but default to false. # The 3rd commit message will be skipped: # Revert "Allow optionally setting thread's daemon but default to false." # # This reverts commit fd27bc2.
|
@joshthecoder Alright I've updated the PR to make it an option to the Stream constructor. What do you think now? Also are there any docs I should update? |
|
Looks good now thanks! Sorry for the long wait on seeing this again |
Harmon758
added
the
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you be open to a PR which sets the daemon flag on async threads?
https://docs.python.org/3/library/threading.html#threading.Thread.daemon
This will allow python scripts to exit cleanly when all non-daemon threads are stopped. The current behavior is that the streaming thread stays up and prevents the script from exiting.
[EDIT]
Changed PR to optionally allow setting daemon flag, but maintain the default behavior of setting it to false.