Direct Message migration #1228
Merged
Direct Message migration #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With API.list_direct_messages
Harmon758
added
API
This was referenced Jun 21, 2019
Closed
Harmon758
removed
the
Need Follow-Up
joshthecoder
approved these changes
Jul 14, 2019
Update testsendanddestroydirectmessage.json and replace testdirectmessages.json and testsentdirectmessages.json with testlistdirectmessages.json
Harmon758
force-pushed
the
dm-migration
branch
2 times, most recently
from
dee0977
to
d051eab
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
DirectMessagemodel (to reflect the new Direct Message Event/Message Create object)API.direct_messagesandAPI.sent_direct_messageswith a newAPI.list_direct_messages(using the new direct_messages/events/list endpoint)API.get_direct_message(using the new direct_messages/events/show endpoint)API.send_direct_message(using the new direct_messages/events/new endpoint)API.destroy_direct_message(using the new direct_messages/events/destroy endpoint)pursuant to the Direct Message migration guide and resolves #1081.
Corresponding documentation, tests, and cassettes are also updated.