Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix #1484

Merged
merged 10 commits into from
Dec 29, 2020
Merged

Doc fix #1484

merged 10 commits into from
Dec 29, 2020

Conversation

dplefevre
Copy link
Contributor

Updated documentation on user_timeline API method: removed 'page' parameter, reordered allowed params to match Twitter API documentation, and added description for 'include_rts'

Copy link
Member

@Harmon758 Harmon758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id should also be removed as an allowed parameter.

docs/api.rst Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
docs/parameters.rst Outdated Show resolved Hide resolved
@Harmon758 Harmon758 added Documentation This is regarding the library's documentation Improvement This is regarding an improvement to an existing feature Need Follow-Up This needs to be followed up on to be actionable labels Dec 26, 2020
@dplefevre
Copy link
Contributor Author

It seems that after removing the ID parameter, test_api.py/testusertimeline() is failing. I have not used nosetest before so I am having a hard time understanding the exact issue at a glance. I am sure I can figure it out if I take some time and look into it, though. Would you like me to try to update the test as well?

@Harmon758
Copy link
Member

No problem, I can update the tests.

@Harmon758 Harmon758 removed the Need Follow-Up This needs to be followed up on to be actionable label Dec 29, 2020
@Harmon758 Harmon758 merged commit fffc1a7 into tweepy:master Dec 29, 2020
@Harmon758 Harmon758 added this to the 4.0 milestone Dec 29, 2020
@dplefevre dplefevre deleted the doc_fix branch December 29, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation This is regarding the library's documentation Improvement This is regarding an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants