Requests support (for real this time) ! #400
Conversation
|
@joshthecoder: Does this look good to merge? |
|
Let's push this into a branch and iterate on it a bit more. We need to fix the tests / Travis plus verify app engine does not break. |
|
I started work on a branch that abstracted the HTTP client out of binder. |
|
@joshthecoder: Requests appears to support app engine (we should test to make sure, however). All of the test failures were rate limit errors - I'm re-running them to check. |
|
@joshthecoder: Does anything else need to be done? |
|
Still digesting it but so far looks good. Not sure yet when it will ship. |
|
Can you please make sure this works for streaming on appengine too? Requests actually just wraps httplib, and appengine's httplib is replaced by urlfetch, and urlfetch doesn't support long-running requests, so I'm pretty sure Requests will not work on appengine. The only way I've gotten tweepy to work on appengine is to copy in my own copy of python's httplib and modify tweepy to use it instead, which forces it to go over sockets instead of urlfetch. This is a pain, but at least it's possible when I can just change the import statement in tweepy/streaming.py. I'd rather not have to change the imports of an external dependency. |
|
@joshthecoder: How is this looking? |
|
@joshthecoder: Ping |
|
Looks like there are some conflicts that need to be resolved. Otherwise its good to merge into master. |
Requests support (for real this time) !
|
Looks like master is failing. I started looking into it. A few coding errors I fixed, but now authentication seems broken. |
|
Okay think I have it fixed now. There does appear to be an issue with the recordings missing some responses though. Not sure yet what is causing it. |
No description provided.