Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config to determine openssl LDFLAGS #17

Closed
wants to merge 1 commit into from
Closed

Use pkg-config to determine openssl LDFLAGS #17

wants to merge 1 commit into from

Conversation

ffontaine
Copy link

Depending on its build configuration, openssl might not be compiled with dynamic zlib support, and programs that link against openssl need to link against zlib as well, as illustrated in this build failure:
http://autobuild.buildroot.net/results/ae9/ae946ca72238840b3eaa5fe823e8d620618f7462/

Signed-off-by: Titouan Christophe titouan.christophe@railnova.eu
[Retrieved (and slightly updated) from:
https://github.com/angeloc/htpdate/commit/72fcf9f82770e927e058a2eaa327d0eecb1e3c8d]
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Depending on its build configuration, openssl might not be compiled with
dynamic zlib support, and programs that link against openssl need to link
against zlib as well, as illustrated in this build failure:
http://autobuild.buildroot.net/results/ae9/ae946ca72238840b3eaa5fe823e8d620618f7462/

Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
[Retrieved (and slightly updated) from:
angeloc/htpdate@72fcf9f]
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@twekkel
Copy link
Owner

twekkel commented Jan 28, 2022

Have seen that commit, but didn't include it deliberately. It introduces an extra dependency on pkg-config being installed.

It looks like ucLibc specific specific issue... can it not be solved in a more elegant way?

@twekkel
Copy link
Owner

twekkel commented Jan 28, 2022

does this make sense to you?

https://github.com/twekkel/htpdate/tree/use-pkg-config

@ffontaine
Copy link
Author

Static build is not related to uclibc-ng, however, I understand that you don't want to add a pkg-config dependency. In this case, I would suggest to move -lssl in a dedicated variable such as SSL_LIBS. Then, I would override SSL_LIBS with the result of pkg-config in buildroot httpdate.mk

@twekkel
Copy link
Owner

twekkel commented Jan 29, 2022

like this?
4ba90fe

@ffontaine
Copy link
Author

Yes, perfect. I'll pull this commit in buildroot, thanks.

@ffontaine ffontaine closed this Jan 29, 2022
@tpetazzoni
Copy link

A bit sad that pkg-config was not used. It could have been used optionally, i.e only if available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants