fix: coerce unexpected severity levels to error (#102)

twelvelabs · Nov 26, 2023 · f3c070c · f3c070c
1 parent 3cd9205
commit f3c070c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/internal/stylist/enums.go b/internal/stylist/enums.go
@@ -31,16 +31,16 @@ type ResultLevel int
 // CoerceResultLevel returns the correct enum for the given value.
 func CoerceResultLevel(value string) (ResultLevel, error) {
 	switch value {
-	case "", "<no value>":
+	case "none", "", "<no value>":
 		return ResultLevelNone, nil
-	case "info", "note":
+	case "info", "note", "style":
 		return ResultLevelInfo, nil
 	case "warn", "warning":
 		return ResultLevelWarning, nil
 	case "err", "error":
 		return ResultLevelError, nil
 	default:
-		return ParseResultLevel(value)
+		return ResultLevelError, nil
 	}
 }
 

diff --git a/internal/stylist/enums_test.go b/internal/stylist/enums_test.go
@@ -163,8 +163,8 @@ func TestCoerceResultLevel(t *testing.T) {
 		},
 		{
 			desc:     "unknown",
-			expected: ResultLevelNone,
-			err:      "unknown is not a valid ResultLevel",
+			expected: ResultLevelError,
+			err:      "",
 		},
 	}
 	for _, tt := range tests {

diff --git a/internal/stylist/result_mapping_test.go b/internal/stylist/result_mapping_test.go
@@ -317,8 +317,7 @@ func TestResultMapping_RenderLevel(t *testing.T) {
 			data: resultData{
 				"level": "unknown",
 			},
-			expected: ResultLevelNone,
-			err:      "unknown is not a valid ResultLevel",
+			expected: ResultLevelError,
 		},
 		{
 			desc:     "should return an error when template fails to render",